server side fixes #892
Merged
server side fixes #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1. make stream_type optional 2. internal stream creation to happen only once and stream creation request sync should not happen every time server restarts 3. time partition field data type change from Utf-8 to Timestamp to happen only when schema has the time partition field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
make stream_type optional
required because offline ingestors will not get upgraded and querier needs to read the stats from all ingestors' stream.json
internal stream creation to happen only once and stream creation request sync should not happen every time server restarts
required because currently everytime internal stream creation request gets forwarded to ingestors which returns error as stream already exists
time partition field data type change from Utf-8 to Timestamp to happen only when schema has the time partition field
required because if stream is created with time partition but no event has been ingested, so no schema exists and if server restarts, it panics because it could not find time partition field in the schema