Skip to content

added validation in alert creation #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2024
Merged

added validation in alert creation #807

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aef6d04
added validation in alert creation
nikhilsinhaparseable Jun 4, 2024
3f11997
Merge branch 'main' into alert-validation
nikhilsinhaparseable Jun 6, 2024
0be5717
Merge branch 'main' into alert-validation
nitisht Jun 7, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions server/src/validator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,19 @@ const DENIED_NAMES: &[&str] = &[
];

pub fn alert(alerts: &Alerts) -> Result<(), AlertValidationError> {
let alert_name: Vec<&str> = alerts.alerts.iter().map(|a| a.name.as_str()).collect();
let mut alert_name_dedup = alert_name.clone();
alert_name_dedup.sort();
alert_name_dedup.dedup();

if alert_name.len() != alert_name_dedup.len() {
return Err(AlertValidationError::ExistingName);
}
for alert in &alerts.alerts {
if alert.name.is_empty() {
return Err(AlertValidationError::EmptyName);
}

if alert.message.message.is_empty() {
return Err(AlertValidationError::EmptyMessage);
}
Expand Down Expand Up @@ -145,6 +154,8 @@ pub mod error {
pub enum AlertValidationError {
#[error("Alert name cannot be empty")]
EmptyName,
#[error("Alert with the same name already exists")]
ExistingName,
#[error("Alert message cannot be empty")]
EmptyMessage,
#[error("Alert's rule.column cannot be empty")]
Expand Down