Skip to content

Set file_size attribute directly from file metadata #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Set file_size attribute directly from file metadata #576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions server/src/catalog/manifest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ pub fn create_from_parquet_file(
};

let file = std::fs::File::open(fs_file_path)?;
manifest_file.file_size = file.metadata()?.len();

let file = parquet::file::serialized_reader::SerializedFileReader::new(file)?;
let file_meta = file.metadata().file_metadata();
let row_groups = file.metadata().row_groups();
Expand All @@ -105,9 +107,6 @@ pub fn create_from_parquet_file(
manifest_file.ingestion_size = row_groups
.iter()
.fold(0, |acc, x| acc + x.total_byte_size() as u64);
manifest_file.file_size = row_groups
.iter()
.fold(0, |acc, x| acc + x.compressed_size() as u64);

let columns = column_statistics(row_groups);
manifest_file.columns = columns.into_values().collect();
Expand Down