Skip to content

Conversation

regularcoder
Copy link
Contributor

Fixes #271.

Description

Increase the request body payload size limit to 10MB

@nitisht nitisht requested a review from trueleo February 1, 2023 05:53
@nitisht
Copy link
Member

nitisht commented Feb 1, 2023

@trueleo PTAL

@trueleo
Copy link
Contributor

trueleo commented Feb 1, 2023

@nitisht This increases the payload size to ~10mb. However just looked at where it is used and it seems like the limit is changed just for logstream service but not for ingest endpoint

trueleo
trueleo previously approved these changes Feb 1, 2023
@regularcoder
Copy link
Contributor Author

Thank you @trueleo for reviewing. So @nitisht it seems logical to also add the limit to /ingest endpoint? After all it seems to serve same purpose.

Also - please let me know if I should go ahead and fix the "warning: variables can be used directly in the format! string" Clippy errors that are unrelated to my change.

@trueleo
Copy link
Contributor

trueleo commented Feb 1, 2023

@regularcoder Yes, /ingest endpoint serves the same purpose as /logstream/{stream_name}. You can put the same JsonConfig to /ingest as well

@nitisht
Copy link
Member

nitisht commented Feb 1, 2023

Thanks for the PR @regularcoder please proceed with the ingest changes as well. We can then merge this. You can ignore the clippy failure.

@nitisht nitisht merged commit 84e3dd9 into parseablehq:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants