Skip to content

Conversation

nikhilsinhaparseable
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented Sep 2, 2025

Summary by CodeRabbit

  • Refactor

    • Removed the audit logging subsystem and associated HTTP middleware; audit events are no longer emitted or available.
  • Chores

    • Removed audit-related CLI options and environment variables (logger endpoint, username, password).
    • Removed audit-related deployment and build configuration entries.
  • Documentation

    • Updated references and configuration docs to reflect removal of audit logging.
Copy link
Contributor

coderabbitai bot commented Sep 2, 2025

Walkthrough

Removes the audit logging subsystem and its CLI options, deletes HTTP audit middleware and its wiring, drops crate-level audit module export, and promotes KINESIS_COMMON_ATTRIBUTES_KEY to public.

Changes

Cohort / File(s) Summary of changes
Audit subsystem removal
src/audit.rs, src/lib.rs, src/cli.rs
Deleted the audit module (src/audit.rs) and all public types/builders; removed pub mod audit; from src/lib.rs; removed CLI options audit_logger, audit_username, and audit_password from Options.
HTTP audit middleware removal
src/handlers/http/audit.rs, src/handlers/http/mod.rs, src/handlers/http/modal/mod.rs
Removed src/handlers/http/audit.rs (audit_log_middleware implementation), deleted mod audit; declaration, and removed the audit middleware from the HTTP app middleware chain.
Visibility adjustment
src/handlers/mod.rs
Promoted KINESIS_COMMON_ATTRIBUTES_KEY from a private const to pub const.
CI / Helm config cleanup
.github/workflows/build.yaml, helm/values.yaml
Removed cmake from macOS Homebrew install list; deleted auditLogging block from Helm values for parseable deployment.

Sequence Diagram(s)

sequenceDiagram autonumber participant C as Client participant S as HTTP Server participant M as Audit Middleware (removed) participant H as Request Handler participant A as Audit Service rect rgb(245,245,255) note over S,M: Previous flow (with audit) C->>S: HTTP Request S->>M: Invoke middleware M->>M: Build AuditLog M->>H: Forward request H-->>M: Response / Error M->>A: Send audit log (async) M-->>S: Return response S-->>C: HTTP Response end 
Loading
sequenceDiagram autonumber participant C as Client participant S as HTTP Server participant H as Request Handler rect rgb(245,255,245) note over S: New flow (no audit) C->>S: HTTP Request S->>H: Route to handler H-->>S: Response / Error S-->>C: HTTP Response end 
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested reviewers

  • parmesant

Poem

A hop and a skip, I prune with delight,
Old logs tucked away, gone from the night.
Middleware burrow cleared, pathways bright—
Fewer crumbs to chase, quicker flight. 🥕
Public keypeek pops out to say hi.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f20a542 and 518a94a.

📒 Files selected for processing (2)
  • .github/workflows/build.yaml (0 hunks)
  • helm/values.yaml (0 hunks)
💤 Files with no reviewable changes (2)
  • .github/workflows/build.yaml
  • helm/values.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Quest Smoke and Load Tests for Standalone deployments
  • GitHub Check: Quest Smoke and Load Tests for Distributed deployments
  • GitHub Check: Build Default x86_64-apple-darwin
  • GitHub Check: Build Default aarch64-unknown-linux-gnu
  • GitHub Check: Build Default x86_64-pc-windows-msvc
  • GitHub Check: Build Default aarch64-apple-darwin
  • GitHub Check: Build Default x86_64-unknown-linux-gnu
  • GitHub Check: Build Kafka x86_64-unknown-linux-gnu
  • GitHub Check: Build Kafka aarch64-apple-darwin
  • GitHub Check: coverage
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/handlers/mod.rs (1)

46-46: Making KINESIS_COMMON_ATTRIBUTES_KEY public is a safe, additive change.

This improves reuse for integrations parsing Firehose requests; no breaking impact.

Consider adding a brief doc comment explaining when this header is present (e.g., Firehose common attributes).

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f10b28a and f20a542.

📒 Files selected for processing (7)
  • src/audit.rs (0 hunks)
  • src/cli.rs (0 hunks)
  • src/handlers/http/audit.rs (0 hunks)
  • src/handlers/http/mod.rs (0 hunks)
  • src/handlers/http/modal/mod.rs (1 hunks)
  • src/handlers/mod.rs (1 hunks)
  • src/lib.rs (0 hunks)
💤 Files with no reviewable changes (5)
  • src/cli.rs
  • src/handlers/http/mod.rs
  • src/lib.rs
  • src/handlers/http/audit.rs
  • src/audit.rs
🧰 Additional context used
🧬 Code graph analysis (1)
src/handlers/http/modal/mod.rs (1)
src/handlers/http/mod.rs (1)
  • cross_origin_config (70-76)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Quest Smoke and Load Tests for Distributed deployments
  • GitHub Check: Quest Smoke and Load Tests for Standalone deployments
  • GitHub Check: coverage
  • GitHub Check: Build Default aarch64-unknown-linux-gnu
  • GitHub Check: Build Default x86_64-pc-windows-msvc
  • GitHub Check: Build Default x86_64-unknown-linux-gnu
  • GitHub Check: Build Default x86_64-apple-darwin
  • GitHub Check: Build Default aarch64-apple-darwin
  • GitHub Check: Build Kafka x86_64-unknown-linux-gnu
@nikhilsinhaparseable nikhilsinhaparseable merged commit a273e4f into parseablehq:main Sep 2, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant