-
- Notifications
You must be signed in to change notification settings - Fork 153
chore: remove audit logging related changes #1423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove audit logging related changes #1423
Conversation
WalkthroughRemoves the audit logging subsystem and its CLI options, deletes HTTP audit middleware and its wiring, drops crate-level audit module export, and promotes KINESIS_COMMON_ATTRIBUTES_KEY to public. Changes
Sequence Diagram(s)sequenceDiagram autonumber participant C as Client participant S as HTTP Server participant M as Audit Middleware (removed) participant H as Request Handler participant A as Audit Service rect rgb(245,245,255) note over S,M: Previous flow (with audit) C->>S: HTTP Request S->>M: Invoke middleware M->>M: Build AuditLog M->>H: Forward request H-->>M: Response / Error M->>A: Send audit log (async) M-->>S: Return response S-->>C: HTTP Response end sequenceDiagram autonumber participant C as Client participant S as HTTP Server participant H as Request Handler rect rgb(245,255,245) note over S: New flow (no audit) C->>S: HTTP Request S->>H: Route to handler H-->>S: Response / Error S-->>C: HTTP Response end Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/handlers/mod.rs (1)
46-46
: Making KINESIS_COMMON_ATTRIBUTES_KEY public is a safe, additive change.This improves reuse for integrations parsing Firehose requests; no breaking impact.
Consider adding a brief doc comment explaining when this header is present (e.g., Firehose common attributes).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
src/audit.rs
(0 hunks)src/cli.rs
(0 hunks)src/handlers/http/audit.rs
(0 hunks)src/handlers/http/mod.rs
(0 hunks)src/handlers/http/modal/mod.rs
(1 hunks)src/handlers/mod.rs
(1 hunks)src/lib.rs
(0 hunks)
💤 Files with no reviewable changes (5)
- src/cli.rs
- src/handlers/http/mod.rs
- src/lib.rs
- src/handlers/http/audit.rs
- src/audit.rs
🧰 Additional context used
🧬 Code graph analysis (1)
src/handlers/http/modal/mod.rs (1)
src/handlers/http/mod.rs (1)
cross_origin_config
(70-76)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
- GitHub Check: coverage
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: Build Default x86_64-apple-darwin
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
Summary by CodeRabbit
Refactor
Chores
Documentation