Skip to content

feat: Remove ParseFacebookUtils and ParseTwitterUtils #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 8, 2024
Merged

feat: Remove ParseFacebookUtils and ParseTwitterUtils #1779

merged 9 commits into from
Apr 8, 2024

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Apr 6, 2024 •
edited
Loading

New Pull Request Checklist

Issue Description

Closes: #1780
Closes: #1775
Closes: #1764
Closes: #1773

Approach

Remove ParseFacebookUtils and ParseTwitterUtils
@parse-github-assistant Parse GitHub Assistant
Copy link

parse-github-assistant bot commented Apr 6, 2024 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!
@mtrezza mtrezza changed the title feat: Remove PFFacebookUtils and `PFTwitterUtils feat: Remove ParseFacebookUtils and `ParseTwitterUtils Apr 6, 2024
@mtrezza mtrezza changed the title feat: Remove ParseFacebookUtils and `ParseTwitterUtils feat: Remove ParseFacebookUtils and ParseTwitterUtils Apr 6, 2024
@mtrezza mtrezza requested a review from a team April 6, 2024 21:27
@codecov Codecov
Copy link

codecov bot commented Apr 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.27%. Comparing base (dd05d41) to head (a7e6abe).

❗ Current head a7e6abe differs from pull request most recent head debd72b. Consider uploading reports for the commit debd72b to get more accurate results

Additional details and impacted files 
@@ Coverage Diff @@ ## master #1779 +/- ## ========================================== + Coverage 64.24% 72.27% +8.03%  ========================================== Files 201 148 -53 Lines 23233 17267 -5966 ========================================== - Hits 14926 12480 -2446  + Misses 8307 4787 -3520

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@mtrezza mtrezza force-pushed the feat/remove-utils branch from 03e1e2b to ec3fb42 Compare April 7, 2024 21:42
@mtrezza
Copy link
Member Author

mtrezza commented Apr 7, 2024

Change log entry:

BREAKING CHANGE: Removes convenience utilities ParseFacebookUtils and ParseTwitterUtils, instead add the 3rd party authentication SDK to log in and provide the authentication data to PFUser.logInWithAuthType to link the Parse User.
@mtrezza mtrezza merged commit f1311ee into parse-community:master Apr 8, 2024
This was referenced Apr 8, 2024
Closed
Closed
@mtrezza mtrezza deleted the feat/remove-utils branch April 8, 2024 14:03
parseplatformorg pushed a commit that referenced this pull request Apr 8, 2024
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
ef9b00d 
# [3.0.0](2.7.3...3.0.0) (2024-04-08) ### Features * Add `PFObject.isDataAvailableForKey` to check if data is available for individual key ([#1756](#1756)) ([dd05d41](dd05d41)) * Remove `ParseFacebookUtils` and `ParseTwitterUtils` ([#1779](#1779)) ([f1311ee](f1311ee)) ### BREAKING CHANGES * Removes convenience modules `ParseFacebookUtils` and `ParseTwitterUtils`, instead manually add the 3rd party authentication service SDK to log in and provide the authentication data to `PFUser.logInWithAuthType` to link the Parse User. ([f1311ee](f1311ee))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.0.0
@parseplatformorg parseplatformorg added the state:released Released as stable version label Apr 8, 2024
eeallen1 added a commit to eeallen1/Parse-SDK-iOS-OSX that referenced this pull request May 6, 2024
@eeallen1
Merge commit 'ef9b00de9eeeca7fddfe9439141f5141ff5dac02'
53e8034 
* commit 'ef9b00de9eeeca7fddfe9439141f5141ff5dac02': (86 commits) chore(release): 3.0.0 [skip ci] ci: Fix release workflow (parse-community#1782) feat: Remove `ParseFacebookUtils` and `ParseTwitterUtils` (parse-community#1779) feat: Add `PFObject.isDataAvailableForKey` to check if data is available for individual key (parse-community#1756) ci: Bump ip from 2.0.0 to 2.0.1 (parse-community#1772) ci: Fix failing CI by pinning bundler version (parse-community#1778) refactor: Remove Carthage dependency (parse-community#1763) refactor: Remove OCMock Carthage dependency (parse-community#1754) ci: Run CI on Xcode 15 and macOS 13 (parse-community#1753) refactor: Update ruby dependencies (parse-community#1752) refactor: Remove framework builder for assets (parse-community#1751) chore(release): 2.7.3 [skip ci] fix: Compilation errors in `ParseLiveQuery` using `Starscream` 4.0.6 (parse-community#1749) docs: Add changelog note about missing assets (parse-community#1750) chore(release): 2.7.2 [skip ci] fix: Compilation errors `Undefined symbol` and `SystemConfiguration not found` on watchOS (parse-community#1748) ci: Remove publishing release assets (parse-community#1745) ci: Fix and build Starter Projects (parse-community#1744) chore(release): 2.7.1 [skip ci] fix: Compilation error on macOS `Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler` (parse-community#1739) ...
@mathieulb
Copy link

@mtrezza , is there any official documentation on how to « add the 3rd party authentication SDK to log in and provide the authentication data to PFUser.logInWithAuthType to link the Parse User » ? According to the front page, the documentation is supposed to be at https://docs.parseplatform.org/ios/guide/ , but in there, the sample code still refers to PFFacebookUtils, which causes Cannot find 'PFFacebookUtils' in scope with ParseObjC >= 3.0.

Likewise for PFTwitterUtils.
@mathieulb
Copy link

@mtrezza , In the meantime, I added to my project all *.h and *.m from all Source and Internal folders of ParseFacebookUtils, ParseFacebookUtilsiOS and ParseTwitterUtils, added a Bridging-Header.h, fixed a few #import lines & added back NSInteger const kPFErrorFacebookInvalidSession = 251;. That fixed what this pull-request broke. It required installing Facebook SDK < 17, because 17 breaks compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:breaking state:released Released as stable version
3 participants
@mtrezza @parseplatformorg @mathieulb