fix: implementation via CocoaPods fails due to missing FBSDKCoreKit dependency #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
4 tasks
mtrezza changed the title 
| is there any way we can merge this? @mtrezza |
| @StevenMasini Hasn't requested a review yet, so I'm not sure, is this ready? Does it fix the issue for you? |
| I don't know to be honest. I can't say for sure until it gets merged. or maybe manually indicate his branch in Podfile? |
| @mtrezza I am just wondering what's wrong with the |
4 tasks
| Yes, doesn't seem related, I'll go ahead and merge. |
mtrezza changed the title FBSDKCoreKit dependency 
parseplatformorg pushed a commit that referenced this pull request Oct 26, 2022
## [1.19.4](1.19.3...1.19.4) (2022-10-26) ### Bug Fixes * implementation via CocoaPods fails due to missing `FBSDKCoreKit` dependency ([#1666](#1666)) ([ac8a4fa](ac8a4fa))
| 🎉 This change has been released in version 1.19.4 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Adding subspec
Parse/FacebookUtilsto a project will generate linking compilation issues, caused by the missing dependencyFBSDKCoreKit.Related issue: #1665
Approach
TODOs before merging