Skip to content

Conversation

markuswinkler
Copy link
Contributor

FBSDK change from 5.x to 6.x

@TomWFox TomWFox linked an issue Apr 21, 2020 that may be closed by this pull request
@TomWFox
Copy link
Contributor

TomWFox commented Apr 21, 2020

Thanks, we’ve got a few failed tests but they are the usual culprits.

@markuswinkler
Copy link
Contributor Author

I didn't change anything besides the FBSDK reference 😅

@TomWFox
Copy link
Contributor

TomWFox commented Apr 21, 2020

The Cartfile also needs updating.

@markuswinkler
Copy link
Contributor Author

Oops. Done.

@drdaz
Copy link
Member

drdaz commented Apr 22, 2020

There's a script that needs updating in the project file too. I'll try and look at it later today.

@drdaz
Copy link
Member

drdaz commented Apr 22, 2020

No script update needed. We've been downloading and linking version 6 since it was released for the static builds (it downloads the latest)... lucky there were no breaking API changes for us with this release 🙂.

@drdaz drdaz self-requested a review May 5, 2020 10:33
Copy link
Member

@drdaz drdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly this looks fine to me. The FB library builds and the relevant tests pass.

@drdaz drdaz merged commit 1e1c060 into parse-community:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants