Skip to content

feat: Add support for Flutter 3.10 and 3.13, remove support for Flutter 3.0 #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Oct 16, 2023
Merged

feat: Add support for Flutter 3.10 and 3.13, remove support for Flutter 3.0 #971

merged 29 commits into from
Oct 16, 2023

Conversation

mbfakourii
Copy link
Member

Pull Request

Issue

Closes: #968

Approach

Improve support policy and CI

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
mbfakourii and others added 14 commits May 25, 2023 09:12
@parse-github-assistant
Copy link

Thanks for opening this pull request!
@mbfakourii mbfakourii requested a review from a team October 7, 2023 15:26
@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dc7e3d6) 39.63% compared to head (bc63c01) 39.60%.

Additional details and impacted files 
@@ Coverage Diff @@ ## master #971 +/- ## ========================================== - Coverage 39.63% 39.60% -0.04%  ========================================== Files 60 60 Lines 3333 3333 ========================================== - Hits 1321 1320 -1  - Misses 2012 2013 +1

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@mbfakourii mbfakourii added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Oct 7, 2023
mtrezza
mtrezza approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
@mtrezza
Copy link
Member

mtrezza commented Oct 8, 2023

Does this PR depend on #969 or can we already merge it?
@mbfakourii
Copy link
Member Author

Does this PR depend on #969 or can we already merge it?

yes
@mtrezza
Copy link
Member

mtrezza commented Oct 8, 2023

Yes we can merge it or yes we should wait :-)
@mbfakourii
Copy link
Member Author

mbfakourii commented Oct 8, 2023 •
edited
Loading

Yes we can merge it or yes we should wait :-)

Yes we can merge it. 😃
mtrezza
mtrezza requested changes Oct 8, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost forgot that we need to bump the version and add the changelog entry manually; could you please add one?

## [7.0.0](https://github.com/parse-community/Parse-SDK-Flutter/compare/flutter-6.0.0...flutter-7.0.0) (2023-07-18) ### BREAKING CHANGES * This release removes support for Flutter 3.0 ([#971](https://github.com/parse-community/Parse-SDK-Flutter/pull/971)) ### Features * Add support for Flutter 3.10 and 3.13, remove support for Flutter 3.0 ([#971](https://github.com/parse-community/Parse-SDK-Flutter/pull/971))
@mtrezza mtrezza mentioned this pull request Oct 8, 2023
Merged
2 tasks
@mbfakourii
Copy link
Member Author

I almost forgot that we need to bump the version and add the changelog entry manually; could you please add one?

## [7.0.0](https://github.com/parse-community/Parse-SDK-Flutter/compare/flutter-6.0.0...flutter-7.0.0) (2023-07-18) ### BREAKING CHANGES * This release removes support for Flutter 3.0 ([#971](https://github.com/parse-community/Parse-SDK-Flutter/pull/971)) ### Features * Add support for Flutter 3.10 and 3.13, remove support for Flutter 3.0 ([#971](https://github.com/parse-community/Parse-SDK-Flutter/pull/971))

Done
mtrezza
mtrezza reviewed Oct 9, 2023
View reviewed changes
mtrezza
mtrezza reviewed Oct 12, 2023
View reviewed changes
mtrezza
mtrezza requested changes Oct 15, 2023
View reviewed changes
mtrezza
mtrezza requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm re-adding the brackets to prevent bugs, they are added to make dir changes in a sub shell.
mtrezza
mtrezza reviewed Oct 16, 2023
View reviewed changes
mtrezza
mtrezza approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
@mtrezza mtrezza merged commit 1ae0808 into parse-community:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message
3 participants
@mbfakourii @mtrezza @RodrigoSMarques