Skip to content

Conversation

abubkr-hago
Copy link

New Pull Request Checklist

Issue Description

Current AndroidGradlePlugin is 7.1.3.

Closes: #1212.

Approach

Upgrade AGP and gradle-wrapper and modify code syntax accordingly.

TODOs before merging

  • No tests required.
  • No documentation changes required.
Copy link

parse-github-assistant bot commented Aug 17, 2024

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!
@mtrezza mtrezza mentioned this pull request Aug 17, 2024
4 tasks
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is upgrading AGP a breaking change, or does that only affect how the SDK itself is built?

@abubkr-hago
Copy link
Author

Is upgrading AGP a breaking change, or does that only affect how the SDK itself is built?

It is not a breaking change, it only changes the build tools.
Updating these dependencies allows the use of JDK_17 which is faster than JDK_11 and has more features.

@mtrezza
Copy link
Member

mtrezza commented Oct 5, 2024

Could you resolve the conflict, so we can merge this?

Edit: tried to resolve the conflicts, waiting for CI...

Copy link
Contributor

@azlekov azlekov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! LGTM!

@mtrezza mtrezza closed this Oct 31, 2024
@mtrezza mtrezza reopened this Oct 31, 2024
@abubkr-hago abubkr-hago closed this by deleting the head repository Mar 19, 2025
@mtrezza
Copy link
Member

mtrezza commented Mar 20, 2025

Too bad this was closed, it was quite a huge PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants