Strict parsing for core
#448
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Some types in
Response
were missingdeny_unknown_fields
that would cause invalid response to be parsed correctly whenDeserializing
.However later I started thinking if having a less strict version would be useful as well, hence I introduced the
strict
feature.I'd like to hear your opinions on whether we want to maintain
strict
andnon-strict
versions or rather default tostrict
.See: tomusdrw/rust-web3#222 (comment) why non strict mode would be useful.