containerCss backgroundColor: 'transparent' #2658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
var containerCSS = { ... backgroundColor: this.opt.backgroundColor || 'transparent' }; white backgroundColor of containerCss overwrites the background of html2canvas. changed to transparent and also add an option to set backgroundColor from opt of jsPDF. 
| Would be not cleaner to set the backgroundColor in the the opt object at about line 156 and set it default to transparent and then reference only the this.opt.backgroundColor instead of "white"? |
| That makes sense. Just updated. Thanks! |
kakugiki changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
var containerCSS = {
...
backgroundColor: this.opt.backgroundColor || 'transparent'
};
white backgroundColor of containerCss overwrites the background of html2canvas. changed to transparent and also add an option to set backgroundColor from opt of jsPDF.