TST: parametrize Excel autofilter edge cases #63220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
antznette1 force-pushed the autofilter-feature branch from a092a84 to 6f55160 Compare 
Member
| Thanks @antznette1 - agreed the test cases adding here look good. Looks like they are failing though. |
rhshadrach added IO Excel Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In respect to your suggestion, @rhshadrach:
I’ve rebased this branch on main so it now includes the parametrized autofilter tests in TestExcelWriter in test_writers.py. To avoid duplicated coverage:
header=False) into TestExcelWriter as parametrized tests overengine.This way, all shared autofilter behavior is tested once, in the parametrized suite, and any future engines will automatically get this coverage.
This PR replaces #62928