BUG: Series.resample failing for non-nanosecond unit that's out of bounds for nano reso #62955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…unds for nano reso
phofl added Resample 
jbrockmendel reviewed Nov 3, 2025
| pandas_datetime_to_datetimestruct(val, creso, &dts) | ||
| else: | ||
| # Plain datetime/date | ||
| pydate_to_dtstruct(stamp, &dts) |
There was a problem hiding this comment.
should this by pydatetime_to_dtstruct?
There was a problem hiding this comment.
I wondered about this too but we seem to be using the date version a little earlier in the callstsack as well
I think we actually never get here with a real datetime
There was a problem hiding this comment.
i guess datetime subclasses date, so this should be safe.
| small comment, otherwise LGTM |
| thanks @phofl |
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.