Skip to content

When getting the numpy datatype, return datetime64[D] for pa.Date32 and return datetime64[ms] for pa.Date64 #62913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
linicole74 wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

When getting the numpy datatype, return datetime64[D] for pa.Date32 and return datetime64[ms] for pa.Date64 #62913

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5071e11
When finding the common type, return the original type if there is on…
Oct 30, 2025
38ba1bd
Add bug to changelog
Oct 30, 2025
829f8a0
Merge branch 'main' into bug-get-common-dtype-date32-pyarrow
Nov 8, 2025
4b0a90c
change pyarrow dtype of date32 and date64 to day and ms granularity
Nov 8, 2025
9241196
working on tests
Nov 8, 2025
0f31992
xfail date64 tests
Nov 8, 2025
3fea3e0
working on tests
Nov 8, 2025
ac77415
remove print statement from test
Nov 8, 2025
608a43d
lint
Nov 8, 2025
d3680a1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 8, 2025
7ff8825
skip pyarrow tests if no pyarrow
Nov 8, 2025
220e290
ruff format
Nov 8, 2025
a187f86
removing xfail
Nov 9, 2025
74552ce
xfail date64
Nov 9, 2025
495f85e
remove date type as xfail in test_get_common_dtype
Nov 9, 2025
a4f89dd
xfail is_date64 for test_get_common_dtype
Nov 9, 2025
ea3f900
remove pyarrow tests from test_find_common_type, already covered by t…
Nov 9, 2025
4cff244
Merge branch 'pandas-dev:main' into bug-get-common-dtype-date32-pyarrow
linicole74 Nov 9, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
working on tests
  • Loading branch information
nli307 committed Nov 8, 2025
commit 3fea3e0a3f66a1487521ba61355d25daa4bcd7da
5 changes: 2 additions & 3 deletions pandas/tests/dtypes/cast/test_find_common_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,8 @@ def test_pyarrow_date_dtypes(dtypes, expected):
>>> pa.from_numpy_dtype(np.dtype('datetime64[ms]'))
TimestampType(timestamp[ms])

To fix this test, we would need to have
>>> pa.from_numpy_dtype(np.dtype('datetime64[ms]'))
DataType(date64[ms])
To fix this test, we would need to have an exception
that makes datetime64[ms] convert to date64[ms].

But date64 isn't the same as datetime64[ms]. date64
is meant to represent a date (without time) only,
Expand Down
Loading