Skip to content

TST: update expected dtype for sum of decimals with pyarrow 21+ #61799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jorisvandenbossche
Copy link
Member

This should fix the failure we started having for the pyarrow nightly build (behaviour change in apache/arrow#44184 to increase the precision of the resulting decimal for sum)

@jorisvandenbossche jorisvandenbossche added this to the 2.3.1 milestone Jul 7, 2025
@jorisvandenbossche jorisvandenbossche added Testing pandas testing functions or related to the test suite Arrow pyarrow functionality labels Jul 7, 2025
@jorisvandenbossche
Copy link
Member Author

Apologies for going quickly here, but going to merge this to have green CI on 2.3.x for releasing

@jorisvandenbossche jorisvandenbossche merged commit ebca3c5 into pandas-dev:main Jul 7, 2025
52 checks passed
@jorisvandenbossche jorisvandenbossche deleted the ci-pyarrow-decimal-sum branch July 7, 2025 13:41
Copy link

lumberbot-app bot commented Jul 7, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x git pull 
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ebca3c56c1f9454ef5d2de5bb19ce138e1619504 
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #61799: TST: update expected dtype for sum of decimals with pyarrow 21+' 
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-61799-on-2.3.x 
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #61799 on branch 2.3.x (TST: update expected dtype for sum of decimals with pyarrow 21+)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jorisvandenbossche
Copy link
Member Author

Manual backport -> #61801

jorisvandenbossche added a commit that referenced this pull request Jul 7, 2025
…pyarrow 21+ (#61799) (#61801) TST: update expected dtype for sum of decimals with pyarrow 21+ (#61799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Testing pandas testing functions or related to the test suite
1 participant