BUG: ensure to_numeric down-casts to uint64 for large unsigned integers #61766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mroeschke reviewed Jul 3, 2025
| # parsing large Python ints), attempt a direct cast to uint64 as a | ||
| # last resort. This addresses GH#14422 where `to_numeric` failed to | ||
| # downcast `[0, 9223372036854775808]` to ``uint64``. | ||
| if ( |
There was a problem hiding this comment.
Could you investigate why this isn't being done in maybe_downcast_numeric instead?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
to_numeric(..., downcast="unsigned") failed to honour the requested
uint64 dtype when values exceeded
np.iinfo(np.int64).max, returningfloat64instead and losing integer precision (GH #14422 /test_downcast_uint64).
Added a fallback that detects integral, non-negative float results and
safely casts them to
np.uint64. All existing logic remains unchangedfor other code paths; the previously xfailed test now passes.