ENH: set __module__ for Dtype and Index classes #59909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 4 commits September 27, 2024 13:49
… the set module decorator and decorating the class. Tested the modification by adding an assert statement to the already existing test_set_module test function
…pe ArrowDtype clasess by decorating them with the set module decorator. Tested the modification by adding an assert statement to the already existing test_set_module test function
jorisvandenbossche added the Output-Formatting 
| This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
jorisvandenbossche approved these changes Nov 7, 2024
There was a problem hiding this comment.
Apologies for the slow follow-up, but this looks all good!
I just updated it with the latest main branch, fixed up CategoricalIndex (you added it to the tests, but didn't decorate that one) and ran our linting on the code.
@Amir-101 thanks again for the contribution!
jorisvandenbossche changed the title 15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Modified top-level name object for all Types class in the Dtype module by importing the set module decorator and decorating the class. Tested the modification by adding an assert statement to the already existing test_set_module test function
__module__on top-level public objects #55178doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.