Skip to content

REF: Defer creating Index._engine until needed #58370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024
Merged

REF: Defer creating Index._engine until needed #58370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
REF: Defer creating Index._engine until needed
  • Loading branch information
@mroeschke
mroeschke committed Apr 22, 2024
commit e38e854f7023cc70c71b3ccf1ff35e9d73448671
3 changes: 1 addition & 2 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4012,7 +4012,6 @@ def _get_value(self, index, col, takeable: bool = False) -> Scalar:
return series._values[index]

series = self._get_item(col)
engine = self.index._engine

if not isinstance(self.index, MultiIndex):
# CategoricalIndex: Trying to use the engine fastpath may give incorrect
Expand All @@ -4023,7 +4022,7 @@ def _get_value(self, index, col, takeable: bool = False) -> Scalar:

# For MultiIndex going through engine effectively restricts us to
# same-length tuples; see test_get_set_value_no_partial_indexing
loc = engine.get_loc(index)
loc = self.index._engine.get_loc(index)
return series._values[loc]

def isetitem(self, loc, value) -> None:
Expand Down
3 changes: 2 additions & 1 deletion pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,7 +832,8 @@ def _reset_identity(self) -> None:

@final
def _cleanup(self) -> None:
self._engine.clear_mapping()
if "_engine" in self._cache:
self._engine.clear_mapping()

@cache_readonly
def _engine(
Expand Down