BUG: checking for value type when parquet is partitioned #54074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mroeschke reviewed Jul 11, 2023
mroeschke requested changes Jul 11, 2023
SanjithChockan changed the title mroeschke reviewed Jul 12, 2023
mroeschke reviewed Jul 12, 2023
mroeschke reviewed Jul 12, 2023
mroeschke reviewed Jul 12, 2023
| | ||
| array = pa | ||
| | ||
| arr = array.array([1, 2, 3], array.dictionary(array.int32(), array.int32())) |
There was a problem hiding this comment.
Could you add a separate test where a dictionary type of strings does work?
There was a problem hiding this comment.
I added a case with valid input and used assert to test if value_type is string
mroeschke reviewed Jul 12, 2023
doc/source/whatsnew/v2.1.0.rst Outdated
| | ||
| ExtensionArray | ||
| ^^^^^^^^^^^^^^ | ||
| - Bug in :class:`ArrowStringArray` constructor raises value error on dictionary on values with string type (:issue:`54074`) |
There was a problem hiding this comment.
Suggested change
| - Bug in :class:`ArrowStringArray` constructor raises value error on dictionary on values with string type (:issue:`54074`) | |
| - Bug in :class:`ArrowStringArray` constructor raises ``ValueError`` with dictionary types of strings (:issue:`54074`) |
mroeschke approved these changes Jul 13, 2023
| Thanks @SanjithChockan |
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Instead of checking pyarrow array's type to be string, it could be a dictionary of values with string type when partitioned. Performed checks for both cases.