Skip to content

DEPR: added deprecation warning for NDFrame.bool #51756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Apr 2, 2023
Merged

DEPR: added deprecation warning for NDFrame.bool #51756

merged 44 commits into from
Apr 2, 2023

Conversation

ramvikrams
Copy link
Contributor

@ramvikrams ramvikrams commented Mar 3, 2023 •
edited
Loading

@ramvikrams ramvikrams changed the title gh-51749 : added deprecation warning gh-51749 : added deprecation warning for NDFrame.bool Mar 3, 2023
MarcoGorelli
MarcoGorelli reviewed Mar 3, 2023
View reviewed changes
@jbrockmendel
Copy link
Member

You'll need to update the docs to remove/suppress deprecated usages
@ramvikrams
Copy link
Contributor Author

ramvikrams commented Mar 3, 2023 •
edited
Loading

You'll need to update the docs to remove/suppress deprecated usages

Sorry, but I coudn't understand can please explain it again or are you talking about adding a whatsnew entry
@rhshadrach
Copy link
Member

@ramvikrams - the method you are deprecating is used in our documentation. Building the docs now emits warnings; the documentation needs to be adjusted so that these warnings no longer appear:

https://github.com/pandas-dev/pandas/actions/runs/4323640786/jobs/7547478298#step:6:67
@rhshadrach rhshadrach changed the title gh-51749 : added deprecation warning for NDFrame.bool DEPR: added deprecation warning for NDFrame.bool Mar 4, 2023
@rhshadrach rhshadrach added the Deprecate Functionality to remove in pandas label Mar 4, 2023
@ramvikrams
Copy link
Contributor Author

@ramvikrams - the method you are deprecating is used in our documentation. Building the docs now emits warnings; the documentation needs to be adjusted so that these warnings no longer appear:

https://github.com/pandas-dev/pandas/actions/runs/4323640786/jobs/7547478298#step:6:67

I actually looked over the net and revious pr's but could not find out how to adjust the documentation , can you please sujjest a walkthrough or any pr that had the same issue
@rhshadrach
Copy link
Member

can you please sujjest a walkthrough or any pr that had the same issue

#51395
@ramvikrams
Copy link
Contributor Author

So should I remove the examples from docstring of bool and other bool instances in the doc
@rhshadrach
Copy link
Member

So should I remove the examples from docstring of bool and other bool instances in the doc

I think you should leave the examples in. You can add them to the filtered warnings here:

pandas/pandas/conftest.py

Line 133 in 27f7365

ignored_doctest_warnings = [

@ramvikrams
Copy link
Contributor Author

@rhshadrach actually now I did the required changes but still Doc Build and Upload fails could you please check
rhshadrach
rhshadrach requested changes Mar 13, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Some requests below.
rhshadrach
rhshadrach requested changes Mar 23, 2023
View reviewed changes
rhshadrach
rhshadrach requested changes Mar 31, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
@rhshadrach
Copy link
Member

/preview
@github-actions
Copy link
Contributor

Website preview of this PR available at: https://pandas.pydata.org/preview/51756/
rhshadrach
rhshadrach requested changes Mar 31, 2023
View reviewed changes
rhshadrach
rhshadrach approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@ramvikrams
Copy link
Contributor Author

@rhshadrach is the PR mergeable now
@rhshadrach rhshadrach added this to the 2.1 milestone Apr 2, 2023
@rhshadrach rhshadrach merged commit d54bd78 into pandas-dev:main Apr 2, 2023
@rhshadrach
Copy link
Member

Thanks @ramvikrams!
@ramvikrams
Copy link
Contributor Author

Thanks @ramvikrams!

thanks sir
@ramvikrams ramvikrams deleted the t03 branch April 2, 2023 12:53
@rhshadrach rhshadrach mentioned this pull request Apr 2, 2023
Closed
topper-123 pushed a commit to topper-123/pandas that referenced this pull request Apr 6, 2023
@ramvikrams @topper-123
DEPR: NDFrame.bool (pandas-dev#51756)
d0bf95c
@topper-123 topper-123 mentioned this pull request Apr 20, 2023
Merged
@mroeschke mroeschke mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deprecate Functionality to remove in pandas

4 participants

@ramvikrams @jbrockmendel @rhshadrach @MarcoGorelli