Skip to content

Use PyCapsule for internal datetime functions #51525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Mar 11, 2023
Merged

Use PyCapsule for internal datetime functions #51525

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
431495b
initial file setup and build
WillAyd Feb 18, 2023
c3dca72
Building standalone impl
WillAyd Feb 18, 2023
d77a2ed
more build
WillAyd Feb 18, 2023
4525e77
linting
WillAyd Feb 18, 2023
782b971
more updates
WillAyd Feb 18, 2023
69abccd
Capsule location change
WillAyd Feb 19, 2023
69460bd
working import
WillAyd Feb 20, 2023
776f0f5
working imports?
WillAyd Feb 20, 2023
c4a05b5
moved lots
WillAyd Feb 20, 2023
a995ee2
Working impl
WillAyd Feb 21, 2023
05e28ad
styling
WillAyd Feb 21, 2023
d938374
import cleanups
WillAyd Feb 21, 2023
df687b3
revert init change
WillAyd Feb 21, 2023
a26f312
cleanups
WillAyd Feb 21, 2023
96b6f96
isort fixups
WillAyd Feb 21, 2023
7b28333
api test fix
WillAyd Feb 21, 2023
ccea2b3
removed unneeded tokenizer add
WillAyd Feb 21, 2023
2bf7264
Hacked together parser capsule
WillAyd Feb 26, 2023
418910d
Symbol cleanups
WillAyd Feb 26, 2023
a4f7e1a
Resolved all undefined symbols in parsers.pyx
WillAyd Feb 26, 2023
ad1d149
IO callbacks restored
WillAyd Feb 26, 2023
5887254
Fix build and test failures
WillAyd Feb 26, 2023
138ea0d
Try relative imports for MSFT compat
WillAyd Feb 26, 2023
679d03d
try py_ssize_t_clean macro
WillAyd Feb 26, 2023
7c4e365
Removed double tokenizer include
WillAyd Feb 26, 2023
5aee18a
removed unneeded include path
WillAyd Feb 26, 2023
a0523be
more cleanups
WillAyd Feb 27, 2023
554d701
noexcept
WillAyd Feb 27, 2023
726d93d
signature cleanup
WillAyd Feb 27, 2023
d2fe542
simplify parser impl
WillAyd Feb 28, 2023
49a2739
retain np_datetime_string license
WillAyd Feb 28, 2023
3981ec2
retained old file structure where possible
WillAyd Feb 28, 2023
fb75100
Commited C file
WillAyd Feb 28, 2023
f51e7f4
Removed erroneous comments
WillAyd Mar 2, 2023
709bf6c
Merge branch 'main' into np-datetime-capsule
WillAyd Mar 2, 2023
f4dac4f
graft pd_parser.c
WillAyd Mar 6, 2023
7fd0a49
Merge branch 'main' into np-datetime-capsule
WillAyd Mar 6, 2023
12179c7
graft -> include
WillAyd Mar 6, 2023
67f5445
Merge remote-tracking branch 'upstream/main' into np-datetime-capsule
WillAyd Mar 9, 2023
9271ce3
Merge branch 'main' into np-datetime-capsule
WillAyd Mar 11, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
import cleanups
  • Loading branch information
@WillAyd
WillAyd committed Feb 21, 2023
commit d93837471b10b6d112e2760aa5da7a760e8f51e6
1 change: 0 additions & 1 deletion pandas/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,6 @@
"offsets",
"option_context",
"options",
"pandas_datetime_CAPI",
"period_range",
"pivot",
"pivot_table",
Expand Down
6 changes: 4 additions & 2 deletions pandas/_libs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,13 @@
"Timestamp",
"iNaT",
"Interval",
"pandas_datetime",
]


import pandas._libs.pandas_datetime as pandas_datetime
# Below import needs to happen first to ensure pandas top level
# module gets monkeypatched with the pandas_datetime_CAPI
# see pandas_datetime_exec in pd_datetime.c
import pandas._libs.pandas_datetime as pandas_datetime # noqa # isort: skip
Copy link
Member Author

@WillAyd WillAyd Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this, but capsules currently cannot be attached to anything but a top level package. See python/cpython#6898 which I think would solve this, but for now this has to be attached to the top level namespace and really come before anything else to avoid circular import errors
from pandas._libs.interval import Interval
from pandas._libs.tslibs import (
NaT,
Expand Down