Skip to content

CLN: Remove unused rewrite warning #50403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2022
Merged

CLN: Remove unused rewrite warning #50403

merged 1 commit into from
Dec 23, 2022

Conversation

@rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Dec 22, 2022

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

With groupby no longer silently dropping nuisance columns, the warning is no longer raised and so this goes unused.
@rhshadrach rhshadrach added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Deprecate Functionality to remove in pandas Clean Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply labels Dec 22, 2022
@rhshadrach rhshadrach added this to the 2.0 milestone Dec 22, 2022
@phofl phofl merged commit 9993ec4 into pandas-dev:main Dec 23, 2022
@phofl
Copy link
Member

phofl commented Dec 23, 2022

thx @rhshadrach
@rhshadrach rhshadrach deleted the cleanup_pivot_table_warning branch December 23, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean Deprecate Functionality to remove in pandas Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Reshaping Concat, Merge/Join, Stack/Unstack, Explode

2 participants

@rhshadrach @phofl