Skip to content

DEPR: deprecate Index.is_floating #50235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 12, 2023
Merged

DEPR: deprecate Index.is_floating #50235

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d37573f
deprecate is_float()
yuuun Dec 13, 2022
5167d8e
Merge branch 'main' into deprecate-Index-is_floating
yuuun Dec 13, 2022
6a080b3
update is_floating()
yuuun Dec 13, 2022
8b86740
update error
yuuun Dec 13, 2022
b18d8db
reorder
yuuun Dec 14, 2022
ce30d07
check indent error
yuuun Dec 14, 2022
aba7816
fixing indent error
yuuun Dec 14, 2022
bce52c6
Merge branch 'main' into deprecate-Index-is_floating
yuuun Dec 14, 2022
39e7333
Merge branch 'main' into deprecate-Index-is_floating
yuuun Dec 15, 2022
9e3027b
Merge branch 'pandas-dev:main' into deprecate-Index-is_floating
yuuun Dec 18, 2022
ec729ec
Merge branch 'main' into deprecate-Index-is_floating
yuuun Dec 18, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
check indent error
  • Loading branch information
@yuuun
yuuun authored Dec 14, 2022
commit ce30d07aa9299d2ee21e132176b8b865af84bca4
10 changes: 5 additions & 5 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2303,11 +2303,11 @@ def is_floating(self) -> bool:
False
"""
warnings.warn(
f"{type(self).__name__}.is_floating is deprecated."
"Use pandas.api.types.is_float_dtype instead",
FutureWarning,
stacklevel=find_stack_level(),
)
f"{type(self).__name__}.is_floating is deprecated."
"Use pandas.api.types.is_float_dtype instead",
Comment on lines +2304 to +2305
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably could do with a space here.
FutureWarning,
stacklevel=find_stack_level(),
)
return self.inferred_type in ["floating", "mixed-integer-float", "integer-na"]

@final
Expand Down