Skip to content

CLN: Add typing for dtype argument in io/sql.py #38680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 29, 2020
Merged

CLN: Add typing for dtype argument in io/sql.py #38680

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e1bc42a
Add typing for io/sql.py
avinashpancham Dec 24, 2020
1aaa6a2
Merge remote-tracking branch 'upstream/master' into typing_dtype
avinashpancham Dec 28, 2020
2c70647
Cast dtype to dict
avinashpancham Dec 28, 2020
a82a6c1
Replace isinstance checks with is_dict_like
avinashpancham Dec 29, 2020
41138e3
Merge remote-tracking branch 'upstream/master' into typing_dtype
avinashpancham Dec 29, 2020
8dc13bd
Revert check to original form
avinashpancham Dec 29, 2020
ae41d91
Remove superfluous if statement
avinashpancham Dec 29, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove superfluous if statement
  • Loading branch information
@avinashpancham
avinashpancham committed Dec 29, 2020
commit ae41d91010c5ab04bc6ca3df48e41da9e17965c5
2 changes: 0 additions & 2 deletions pandas/io/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1501,7 +1501,6 @@ def to_sql(
else:
dtype = cast(dict, dtype)

if dtype is not None:
from sqlalchemy.types import TypeEngine, to_instance

for col, my_type in dtype.items():
Expand Down Expand Up @@ -1970,7 +1969,6 @@ def to_sql(
else:
dtype = cast(dict, dtype)

if dtype is not None:
for col, my_type in dtype.items():
if not isinstance(my_type, str):
raise ValueError(f"{col} ({my_type}) not a string")
Expand Down