Skip to content

Backport PR #38560 on branch 1.2.x (Revert "REF: remove special casing from Index.equals (always dispatchto subclass) (#35330)") #38565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Backport PR #38560 on branch 1.2.x (Revert "REF: remove special casing from Index.equals (always dispatchto subclass) (#35330)") #38565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4455,15 +4455,16 @@ def equals(self, other: object) -> bool:
if not isinstance(other, Index):
return False

# If other is a subclass of self and defines its own equals method, we
# dispatch to the subclass method. For instance for a MultiIndex,
# a d-level MultiIndex can equal d-tuple Index.
# Note: All EA-backed Index subclasses override equals
if (
isinstance(other, type(self))
and type(other) is not type(self)
and other.equals is not self.equals
):
if is_object_dtype(self.dtype) and not is_object_dtype(other.dtype):
# if other is not object, use other's logic for coercion
return other.equals(self)

if isinstance(other, ABCMultiIndex):
# d-level MultiIndex can equal d-tuple Index
return other.equals(self)

if is_extension_array_dtype(other.dtype):
# All EA-backed Index subclasses override equals
return other.equals(self)

return array_equivalent(self._values, other._values)
Expand Down