Skip to content

Conversation

@jorisvandenbossche
Copy link
Member

Closes #38525

Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback jreback added NA - MaskedArrays Related to pd.NA and nullable extension arrays Bug labels Dec 17, 2020
@jreback jreback added this to the 1.3 milestone Dec 17, 2020
@jreback
Copy link
Contributor

jreback commented Dec 17, 2020

lgtm, needs a whatsnew note bug fix (ok for 1.2 or 1.3)

@jorisvandenbossche
Copy link
Member Author

Yeah, I didn't yet add a whatsnew because we need to decide which version to target. Normally, plain bug fixes should go in 1.3 right now, but since this is actually causing a silent data corruption, it might be worth putting in 1.2

@jreback jreback modified the milestones: 1.3, 1.2 Dec 19, 2020
@jreback
Copy link
Contributor

jreback commented Dec 19, 2020

1.2 sounds good to me

@jreback jreback merged commit 572194c into pandas-dev:master Dec 21, 2020
@jreback
Copy link
Contributor

jreback commented Dec 21, 2020

@jreback
Copy link
Contributor

jreback commented Dec 21, 2020

@meeseeksdev backport 1.2.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Dec 21, 2020
@jorisvandenbossche jorisvandenbossche deleted the bug-sliced-arrow-array branch December 21, 2020 13:58
jreback pushed a commit that referenced this pull request Dec 21, 2020
…rray (#38611) Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug NA - MaskedArrays Related to pd.NA and nullable extension arrays

3 participants