TST: add message matches to pytest.raises in various tests GH30999 #38350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| I tried to follow the contributing guidelines as best as I could. If there's any problem, let me know. Edit: Looks like some tests didn't pass. @MarcoGorelli can you give me some pointers on how to fix this? |
arw2019 reviewed Dec 8, 2020
| msg = "invalid coding, encoding must be ascii" | ||
| # test case for testing invalid encoding | ||
| with pytest.raises(ValueError): | ||
| with pytest.raises(ValueError, match=msg): |
Contributor
There was a problem hiding this comment.
looking at the CI the message being thrown is different
Contributor Author
There was a problem hiding this comment.
I thought that the message didn't exist and wrote one, I'll fix them so they match with what's supposed to say. Where can I find the exact message?
Contributor
There was a problem hiding this comment.
run the code that throws the error
Contributor
| thanks @JoseNavy |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffFiles changed:
pandas/tests/io/pytables/test_complex.py
pandas/tests/io/test_clipboard.py
pandas/tests/plotting/frame/test_frame_subplots.py