Skip to content

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh reopened this Mar 19, 2020
@datapythonista datapythonista changed the title CI: Fix CI DOC: FutureWarning in Sphinx build when calling read_parquet Mar 19, 2020
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix @MomIsBestFriend

@ShaharNaveh
Copy link
Contributor Author

ShaharNaveh commented Mar 19, 2020

@datapythonista Is there a reason to limit the line characters length to 80, in rst files?


I don't mean disable the check, but 88 characters seems to me more reasonable rather than 80.

@ShaharNaveh
Copy link
Contributor Author

Even if auto_mkdir=True is passed, it still produces the warning on the CI, but on my local machine passing auto_mkdir=True does solve this issue.

ddf = dd.read_parquet("data/timeseries/ts*.parquet", engine="pyarrow")
ddf = dd.read_parquet(
"data/timeseries/ts*.parquet", engine="pyarrow", auto_mkdir=True
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option is to set :okwarning: for now, as I suppose this is something to be fixed on the dask side

@jorisvandenbossche jorisvandenbossche added this to the 1.0.4 milestone Mar 19, 2020
@jorisvandenbossche
Copy link
Member

@MomIsBestFriend can you just merge master? I just merged another PR that fixes the theme name error you now get

@ShaharNaveh
Copy link
Contributor Author

CI is green :)

@datapythonista datapythonista merged commit e31354f into pandas-dev:master Mar 20, 2020
@datapythonista
Copy link
Member

Thanks for fixing this @MomIsBestFriend

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 20, 2020
@ShaharNaveh ShaharNaveh deleted the CI-sphinx-err branch March 20, 2020 00:40
jorisvandenbossche pushed a commit that referenced this pull request Mar 20, 2020
…ead_parquet (#32847) Co-authored-by: MomIsBestFriend <50263213+MomIsBestFriend@users.noreply.github.com>
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Mar 23, 2020
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants