Skip to content

TST: Check error raised when inserting wrong length categorical column #29523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2019
Merged

TST: Check error raised when inserting wrong length categorical column #29523

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a23c7d6
Check error raised with wrong length cat insertion
ryankarlos Nov 10, 2019
b80a665
Add issue number
ryankarlos Nov 10, 2019
27de8fb
Shift test to pandas/tests/frame/test_indexing.py
ryankarlos Nov 13, 2019
27e7b9c
remove existing duplicate test
ryankarlos Nov 13, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pandas/tests/frame/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3881,3 +3881,11 @@ def test_loc_indexing_preserves_index_category_dtype(self):

result = df.loc[["a"]].index.levels[0]
tm.assert_index_equal(result, expected)

def test_wrong_length_cat_dtype_raises(self):
# GH29523
cat = pd.Categorical.from_codes([0, 1, 1, 0, 1, 2], ["a", "b", "c"])
df = pd.DataFrame({"bar": range(10)})
err = "Length of values does not match length of index"
with pytest.raises(ValueError, match=err):
df["foo"] = cat