Skip to content

API/DEPR: Change default skipna behaviour + deprecate numeric_only in Categorical.min and max #27929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 2, 2019
Merged

API/DEPR: Change default skipna behaviour + deprecate numeric_only in Categorical.min and max #27929

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9fab462
Deprecate numeric_only parameter in Categorical.min and max
makbigc Aug 15, 2019
4bfe686
Amend after 1st review
makbigc Aug 16, 2019
e4d5c38
Parametrize test_min_max_skipna in reductions/test_reductions.py
makbigc Aug 16, 2019
765e506
merge for update
makbigc Oct 30, 2019
300a862
Set skipna=None by default and add future warning
makbigc Nov 1, 2019
095e6da
Fix black issue and the test error
makbigc Nov 1, 2019
f094635
merge for update
makbigc Nov 21, 2019
7d73163
Set skipna=True and add section in API breaking
makbigc Nov 21, 2019
f9d9bc5
merge for update
makbigc Nov 23, 2019
6a184c8
Modify after review
makbigc Nov 23, 2019
ac89bcd
merge for solving conflict
makbigc Nov 26, 2019
9691c44
merge for update
makbigc Nov 27, 2019
d281650
merge for update
makbigc Dec 1, 2019
23ffd16
Remove kwarg in categorical.min and max
makbigc Dec 2, 2019
260201c
Change wording in v1.0.0.rst
makbigc Dec 2, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Parametrize test_min_max_skipna in reductions/test_reductions.py
  • Loading branch information
@makbigc
makbigc committed Oct 7, 2019
commit e4d5c3856c6e3a8a25884a34754c1731f6c1e779
20 changes: 10 additions & 10 deletions pandas/tests/reductions/test_reductions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,21 +1041,21 @@ def test_min_max(self):
assert _min == 2
assert _max == 1

def test_min_max_skipna(self):
@pytest.mark.parametrize("skipna", [True, False])
def test_min_max_skipna(self, skipna):
# GH 25303
cat = Series(
Categorical(["a", "b", np.nan, "a"], categories=["b", "a"], ordered=True)
)
_min = cat.min(skipna=skipna)
_max = cat.max(skipna=skipna)

_min = cat.min()
_max = cat.max()
assert _min == "b"
assert _max == "a"

_min = cat.min(skipna=False)
_max = cat.max(skipna=False)
assert np.isnan(_min)
assert np.isnan(_max)
if skipna is True:
assert _min == "b"
assert _max == "a"
else:
assert np.isnan(_min)
assert np.isnan(_max)


class TestSeriesMode:
Expand Down