DEPS: Grouping deps and adding information to environment.yml #26691
Conversation
| - mypy | ||
| - pycodestyle # used by flake8 | ||
| - pip: | ||
| - cpplint |
There was a problem hiding this comment.
This seems to be available through conda-forge, if we want to switch to that: https://anaconda.org/conda-forge/cpplint. Understood if you want to keep this a purely a reorganization though.
environment.yml Outdated
| - ipywidgets | ||
| - nbformat | ||
| - notebook>=5.7.5 | ||
| - python-snappy |
There was a problem hiding this comment.
This would be for parquet. In the past there was an issue with either pyarrow or fastpaquet essentially requiring snappy compression (I don't recall the details).
| - statsmodels | ||
| | ||
| # unused (required indirectly may be?) | ||
| - ipywidgets |
There was a problem hiding this comment.
I don't recall why this was necessary.
| Fixed |
Codecov Report
@@ Coverage Diff @@ ## master #26691 +/- ## =========================================== - Coverage 91.87% 41.76% -50.12% =========================================== Files 174 174 Lines 50661 50661 =========================================== - Hits 46547 21157 -25390 - Misses 4114 29504 +25390
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@ ## master #26691 +/- ## ========================================== - Coverage 91.87% 91.87% -0.01% ========================================== Files 174 174 Lines 50661 50694 +33 ========================================== + Hits 46547 46577 +30 - Misses 4114 4117 +3
Continue to review full report at Codecov.
|
| are we actually testing this anywhere? IOW do we create an environment based on this? |
| yes, the |
| @datapythonista great, merge on green. |
3 participants
git diff upstream/master -u -- "*.py" | flake8 --diffI didn't add or remove any dependency here. I think it makes more sense to keep exactly the same here that the diff is not so clear, and make changes in a follow up PR if needed.
CC: @jreback @TomAugspurger @jorisvandenbossche