Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Partial PR04 errors fix
  • Loading branch information
mwoss committed Feb 5, 2019
commit 0dc07f2ffe6b2257350eead27f65985eb8816a27
2 changes: 1 addition & 1 deletion pandas/core/algorithms.py
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ def _factorize_array(values, na_sentinel=-1, size_hint=None,
coerced to ndarrays before factorization.
"""),
order=dedent("""\
order
order : None
.. deprecated:: 0.23.0

This parameter has no effect and is deprecated.
Expand Down
6 changes: 4 additions & 2 deletions pandas/core/generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -648,13 +648,15 @@ def transpose(self, *args, **kwargs):
copy : boolean, default False
Make a copy of the underlying data. Mixed-dtype data will
always result in a copy
kwargs : Any additional keyword arguments will be passed as keywords to the function

Returns
-------
----------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't nacessary change, but I thought matching separator in every section will looks good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this - the length needs to match the title name for proper sphinx rendering

y : same as input
asdadasd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, deleted.


Examples
--------
----------
>>> p.transpose(2, 0, 1)
>>> p.transpose(2, 0, 1, copy=True)
"""
Expand Down
2 changes: 1 addition & 1 deletion pandas/core/groupby/groupby.py
Original file line number Diff line number Diff line change
Expand Up @@ -1835,7 +1835,7 @@ def rank(self, method='average', ascending=True, na_option='keep',
The axis of the object over which to compute the rank.

Returns
-----
----------
DataFrame with ranking of values within each group
"""
if na_option not in {'keep', 'top', 'bottom'}:
Expand Down
2 changes: 1 addition & 1 deletion pandas/core/panel.py
Original file line number Diff line number Diff line change
Expand Up @@ -1010,7 +1010,7 @@ def apply(self, func, axis='major', **kwargs):
DataFrames of items & major axis will be passed
axis : {'items', 'minor', 'major'}, or {0, 1, 2}, or a tuple with two
axes
Additional keyword arguments will be passed as keywords to the function
kwargs : Additional keyword arguments will be passed as keywords to the function

Returns
-------
Expand Down
2 changes: 1 addition & 1 deletion pandas/core/resample.py
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,7 @@ def std(self, ddof=1, *args, **kwargs):
Parameters
----------
ddof : integer, default 1
degrees of freedom
degrees of freedom
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the start of the description is always capitalized and ends with a period; otherwise you would be creating a new issue

"""
nv.validate_resampler_func('std', args, kwargs)
return self._downsample('std', ddof=ddof)
Expand Down
7 changes: 4 additions & 3 deletions pandas/io/formats/style.py
Original file line number Diff line number Diff line change
Expand Up @@ -424,9 +424,10 @@ def render(self, **kwargs):

Parameters
----------
`**kwargs` : Any additional keyword arguments are passed through
to ``self.template.render``. This is useful when you need to provide
additional variables for a custom template.
kwargs : Any additional keyword arguments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same on kwargs

keywords are passed throught o ``self.template.render``.
This is useful when you need to provide
additional variables for a custom template.

.. versionadded:: 0.20

Expand Down
2 changes: 1 addition & 1 deletion pandas/io/parquet.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ def read_parquet(path, engine='auto', columns=None, **kwargs):
``io.parquet.engine`` is used. The default ``io.parquet.engine``
behavior is to try 'pyarrow', falling back to 'fastparquet' if
'pyarrow' is unavailable.
kwargs are passed to the engine
kwargs: Any additional kwargs are passed to the engine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a space after kwargs here I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


Returns
-------
Expand Down
2 changes: 1 addition & 1 deletion scripts/validate_docstrings.py
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ def validate_pep8(self):
application = flake8.main.application.Application()
application.initialize(["--quiet"])

with tempfile.NamedTemporaryFile(mode='w') as file:
with tempfile.NamedTemporaryFile(mode='w', encoding="utf-8") as file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you changing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without strict encoding I had a problem with creating validation_errors json.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be required here so please remove. If you are having some sort of issue without this please open as a separate issue

file.write(content)
file.flush()
application.run_checks([file.name])
Expand Down