-
- Notifications
You must be signed in to change notification settings - Fork 19.2k
API: change Timestamp.strptime to raise NotImplementedError #25124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits Select commit Hold shift + click to select a range
fae65a4 BUG: constructor Timestamp.strptime() does not support %z.
saurav-chakravorty edb629e Add doc string to NaT and Timestamp
saurav-chakravorty 8041319 updated the error message
saurav-chakravorty 1d74571 Merge remote-tracking branch 'upstream/master' into timestamp
saurav-chakravorty 2bb6934 Updated whatsnew entry.
saurav-chakravorty cdfe2cc Merge remote-tracking branch 'upstream/master' into timestamp
saurav-chakravorty 275c668 Merge remote-tracking branch 'upstream/master' into timestamp
saurav-chakravorty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add doc string to NaT and Timestamp
- Loading branch information
commit edb629e0d845b00d45dac2d3dbaa211c69ab950e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| | @@ -680,6 +680,12 @@ class Timestamp(_Timestamp): | |
| # Issue 25016. As strptime with %z is not supported in Python 2. | ||
| @classmethod | ||
| def strptime(cls, date_string, format): | ||
| """ | ||
| Timestamp.strptime(string, format) | ||
| | ||
| Function is not implemented as the behavior of datetime.strptime() | ||
| ||
| differs in Python 2 and Python 3. | ||
| """ | ||
| raise NotImplementedError("Timestamp.strptime() is not implmented." | ||
| "Use to_datetime() to parse date strings.") | ||
| | ||
| | ||
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're dropping Python 2 in the next release, so I don't think this comment is needed.