CLN: modernize string formatting #22553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
WillAyd approved these changes Aug 31, 2018
Member
WillAyd left a comment
WillAyd left a comment There was a problem hiding this comment.
Pretty straightforward lgtm on green
Codecov Report
@@ Coverage Diff @@ ## master #22553 +/- ## ======================================= Coverage 92.04% 92.04% ======================================= Files 169 169 Lines 50787 50787 ======================================= Hits 46745 46745 Misses 4042 4042
Continue to review full report at Codecov.
|
Member Author
| @WillAyd green; think we're OK merging without waiting on the senior guys? |
Member
| Yep |
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Broken off from #22283.
git diff upstream/master -u -- "*.py" | flake8 --diff