Skip to content

ENH: Allow literal (non-regex) replacement using .str.replace #16808 #19584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 28, 2018
+105 −37
Merged

ENH: Allow literal (non-regex) replacement using .str.replace #16808 #19584

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fe1f3ad
ENH: Allow literal (non-regex) replacement using .str.replace #16808
Liam3851 Feb 7, 2018
d53cf86
Add versionadded tag to regex param docstring.
Liam3851 Feb 12, 2018
656fd68
Move GH16808 tests to their own method.
Liam3851 Feb 12, 2018
a28ef8f
Fix PEP8 line length in tests.
Liam3851 Feb 12, 2018
c5325ae
Documentation additions/fixes.
Liam3851 Feb 12, 2018
a98bd34
Clarify it is "regex=False" that does not work with compiled regex.
Liam3851 Feb 13, 2018
09c1c9f
ENH: Allow literal (non-regex) replacement using .str.replace #16808
Liam3851 Feb 7, 2018
866db2f
Move GH16808 tests to their own method.
Liam3851 Feb 12, 2018
d0dfc6a
Clarify documentation
Liam3851 Feb 27, 2018
1006e96
Fixup whitespace
TomAugspurger Feb 27, 2018
0b34cac
Retrigger travis-ci
Liam3851 Feb 28, 2018
f2198b0
move Raises
jreback Feb 28, 2018
1371cef
Merge branch 'master' into PR_TOOL_MERGE_PR_19584
jreback Feb 28, 2018
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix PEP8 line length in tests.
  • Loading branch information
@Liam3851 @TomAugspurger
Liam3851 authored and TomAugspurger committed Feb 27, 2018
commit a28ef8fbdcc8d846dc0194d6b3fee8b4024e7012
9 changes: 6 additions & 3 deletions pandas/tests/test_strings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,12 +541,15 @@ def test_replace_literal(self):
result = values.str.replace('f.', 'ba', regex=False)
tm.assert_series_equal(result, exp)

# Cannot do a literal replace if given a callable repl or compiled pattern
# Cannot do a literal replace if given a callable repl or compiled
# pattern
callable_repl = lambda m: m.group(0).swapcase()
compiled_pat = re.compile('[a-z][A-Z]{2}')

pytest.raises(ValueError, values.str.replace, 'abc', callable_repl, regex=False)
pytest.raises(ValueError, values.str.replace, compiled_pat, '', regex=False)
pytest.raises(ValueError, values.str.replace, 'abc', callable_repl,
regex=False)
pytest.raises(ValueError, values.str.replace, compiled_pat, '',
regex=False)

def test_repeat(self):
values = Series(['a', 'b', NA, 'c', NA, 'd'])
Expand Down