CLN: Remove "flake8: noqa" from even more files #15872
Conversation
gfyoung force-pushed the flake8-noqa-clean branch from 988cf7e to 3e610f5 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #15872 +/- ## ========================================== - Coverage 90.99% 90.97% -0.02% ========================================== Files 143 143 Lines 49479 49477 -2 ========================================== - Hits 45021 45010 -11 - Misses 4458 4467 +9
Continue to review full report at Codecov.
|
| print(func, args) | ||
| raise | ||
| | ||
| stack[-1] = value |
There was a problem hiding this comment.
? was this just a copy-paste error?
There was a problem hiding this comment.
Honestly, I have no idea. You should ask yourself that 😄 (your name shows up when I look at the blame for this file)
There was a problem hiding this comment.
yeah, what IS puzzling is that it still works! ok thanks!
There was a problem hiding this comment.
Because Python isn't an interpreted language 😄 (that line of code is unreachable, so we can never get an error there)?
There was a problem hiding this comment.
def load_reduce(self): stack = self.stack args = stack.pop() func = stack[-1] stack[-1] = func(*args) was the original code
There was a problem hiding this comment.
Ah, I see. Are my changes fine as is still?
There was a problem hiding this comment.
yeah, had a bunch of error conditions. That statement was dead code :>
| thanks! |
2 participants
Another round of house-cleaning that builds off #15867. Likely to be the last one for now.