BUG: Set frequency for empty Series #14458
Conversation
| empty = Series(index=pd.DatetimeIndex([])).asfreq('H') | ||
| normal = Series(index=pd.DatetimeIndex(["2016-09-29 11:00"]), | ||
| data=[3]).asfreq('H') | ||
| self.assertEqual(empty.index.freq, normal.index.freq) |
There was a problem hiding this comment.
can u also test for TimedeltaIndex and PeriodIndex? The latter looks work properly, but for assurance.
There was a problem hiding this comment.
call these empty -> expected and normal -> result
use assert_index_equal to compare
There was a problem hiding this comment.
@sinhrks should I add assert it for these types of indices in the same test or should I create separate tests for them?
There was a problem hiding this comment.
can u add to tserirs/tests/test_period(timedelras)?
Codecov Report
@@ Coverage Diff @@ ## master #14458 +/- ## ========================================== - Coverage 91.04% 91.02% -0.03% ========================================== Files 136 136 Lines 49088 49091 +3 ========================================== - Hits 44694 44685 -9 - Misses 4394 4406 +12
Continue to review full report at Codecov.
|
sahildua2305 force-pushed the frequency-series-fix branch 2 times, most recently from 0bb68de to 6d95b3a Compare 
| - Bug in ``pd.pivot_table`` may raise ``TypeError`` or ``ValueError`` when ``index`` or ``columns`` | ||
| is not scalar and ``values`` is not specified (:issue:`14380`) | ||
| is not scalar and ``values`` is not specified (:issue:`14380`) | ||
| - Bug in ``pd.pivot_table`` may raise ``TypeError`` or ``ValueError`` when ``index`` or ``columns`` |
There was a problem hiding this comment.
You repeated here the previous entry
| expected = Series(index=pd.DatetimeIndex( | ||
| ["2016-09-29 11:00"])).asfreq('H') | ||
| result = Series(index=pd.DatetimeIndex(["2016-09-29 11:00"]), | ||
| data=[3]).asfreq('H') |
There was a problem hiding this comment.
Can you create one of the two without using asfreq.
Further, it is not fully clear what is what you actually testing, as the result of the empty series is called expected (you typically call the constructed expected value expected to compare the result of what you want to test)
There was a problem hiding this comment.
@jorisvandenbossche Actually the issue was that we didn't set frequency properly for empty series. Hence I'm testing this particular thing by comparing with frequency of a non-empty Series that we make using similar parameters with an empty one.
| @sahildua2305 Can you update? |
| Got busy with stuff. I will update this soon @jorisvandenbossche |
| can you rebase / update |
| Yes, will do! |
sahildua2305 force-pushed the frequency-series-fix branch from f5e2400 to f39a1bc Compare 
| result = Series(index=pd.DatetimeIndex(["2016-09-29 11:00"]), | ||
| data=[3]).asfreq('H') | ||
| self.assert_index_equal(expected.index, result.index) | ||
| |
There was a problem hiding this comment.
compare the series, e.g. assert_series_equal, and construct the expected directly.
you have two results to compare here, what you currently have labeled as expected and as result.
make another tests where you construct the expected directly (iow, dont' use .asfreq) . IOW you actually should use a direc
pandas/tseries/tests/test_period.py Outdated
| | ||
| def test_asfreq_period_empty_series(self): | ||
| # GH 14340 | ||
| expected = Series(index=pd.PeriodIndex(['2011-1', '2011-2', '2011-3'], |
| can you rebase / update |
sahildua2305 force-pushed the frequency-series-fix branch from f39a1bc to 1494d85 Compare | can you rebase / update |
Add test to verify frequency for empty series Update 0.19.1 whatsnew doc Fix linting; exceeded number of characters on one line Improve tests, add assertion for PeriodIndex as well Refactor tests and move to correct file Move changelog entry from 0.19.1 to 0.20.0
sahildua2305 force-pushed the frequency-series-fix branch from 1494d85 to 384e666 Compare 
| thanks! |
closes pandas-dev#14320 Author: Sahil Dua <sahildua2305@gmail.com> Closes pandas-dev#14458 from sahildua2305/frequency-series-fix and squashes the following commits: 384e666 [Sahil Dua] BUG: Set frequency for empty Series
5 participants
git diff upstream/master | flake8 --diffAlternative to #14340