Skip to content

Conversation

@hamdanal hamdanal changed the title Remove pandas 2.0 deprecations from NDFrame and subclasses pandas 2.0 removals for NDFrame and subclasses May 26, 2024
@hamdanal hamdanal marked this pull request as ready for review May 26, 2024 16:04
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good - don't understand the change in the tests.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented May 28, 2024

So the issue with needing pytest.warns() is that matplotlib got updated to version 3.9.0, which causes the warning. See pandas-dev/pandas#58851 for a bug report that I filed as a result.

Rather than add the pytest.warns() here and in your other PR's, can you change pyproject.toml to reflect a restriction on matplotlib:

matplotlib = "3.8.4" 

And change the pyright version to be >= 1.1.364 since that was used in your tests and why you had to make that change for aggregate()

You'll have to do this in all 4 PR's

@hamdanal hamdanal closed this May 29, 2024
@hamdanal hamdanal reopened this May 29, 2024
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hamdanal

@Dr-Irv Dr-Irv merged commit 40f0b71 into pandas-dev:main May 30, 2024
@hamdanal hamdanal deleted the pandas2-removals-frame-series branch May 30, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants