Fix nightly CI again #824
Merged
Fix nightly CI again #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Dr-Irv requested changes Dec 11, 2023
tests/test_frame.py Outdated
Comment on lines 52 to 54
| def getSeriesData() -> dict[str, pd.Series[float]]: | ||
| return {key: pd.Series([1.0, 2.0]) for key in ("A", "B", "C", "D")} | ||
| |
There was a problem hiding this comment.
This got removed in the pandas dev branch, but I'd like to put back in here the version that was there:
_N = 30 _K = 4 def getCols(k) -> str: return string.ascii_uppercase[:k] def getSeriesData() -> dict[str, Series]: index = makeStringIndex(_N) return { c: pd.Series(np.random.default_rng(i).standard_normal(_N), index=index) for i, c in enumerate(getCols(_K)) }There was a problem hiding this comment.
I added the function as it was in pandas but I inlined unused kwargs in two of the helper functions (makeStringIndex and rands_array).
| This removed |
Pandas 2.1 recommends |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
and remove some old warnings.