BUG: Correct Categorical.codes #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Dr-Irv merged 2 commits into pandas-dev:main from bashtage:issue-111

Jul 11, 2022

Contributor

bashtage commented Jul 7, 2022

Set type to correct type

Closes BUG: Categorical.codes has wrong type. #111 (Replace xxxx with the Github issue number)
Tests added: Please use assert_type() to assert the type of any return value

Dr-Irv requested changes

View reviewed changes

tests/test_series.py Outdated

       npt.NDArray[np.int64],  
     ]  
     cat = pd.Categorical(["a", "b", "a"])  
     codes = cat.codes  
 

Collaborator

Dr-Irv Jul 7, 2022

Can you do this instead?

import np_ndarray_int as follows at the top:

if TYPE_CHECKING: from pandas._typing import np_ndarray_int

Then you can remove the type of codes in the test, and just do:

assert_type(cat.codes, "np_ndarray_int")

bashtage force-pushed the issue-111 branch from 5a0070c to a4599e4 Compare

July 7, 2022 12:25

Dr-Irv requested changes

View reviewed changes

tests/test_series.py Outdated Show resolved Hide resolved

Collaborator

Dr-Irv commented Jul 10, 2022

@bashtage can you add the assert_type() as discussed above? Then we can get this one done.

BUG: Correct Categorical.codes

9f879b7

Set type to correct type

bashtage force-pushed the issue-111 branch from a4599e4 to 3fe0853 Compare

July 10, 2022 23:14

TST: Simplify test using assert_type

a31aeed

bashtage force-pushed the issue-111 branch from 3fe0853 to a31aeed Compare

July 10, 2022 23:25

Contributor Author

bashtage commented Jul 11, 2022

I had to noqa the import to get it to pass flake8 since the import is only used in the assert type.

Dr-Irv approved these changes

View reviewed changes

Collaborator

Dr-Irv left a comment

Thanks @bashtage

Dr-Irv merged commit 963dd5f into pandas-dev:main

Member

twoertwein commented Jul 11, 2022

I had to noqa the import to get it to pass flake8 since the import is only used in the assert type.

The second argument of assert_type can not only be of type str but also the type itself.

bashtage deleted the issue-111 branch

July 11, 2022 15:45

Contributor Author

bashtage commented Jul 11, 2022

@twoertwein When I remove the quotes it doesn't work in two different ways:

If I leave the if TYPE_CHCKING on the import, pytest fails NameError: name 'np_ndarray_int' is not defined
If I take away the if TYPECHECKING on the import, I get ImportError: cannot import name 'np_ndarray_int' from 'pandas._typing'

Collaborator

Dr-Irv commented Jul 11, 2022

I got around this issue in test_timefuncs.py by defining np_ndarray_bool there. Could use that pattern here as well, if desired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment