Implements Fields builder #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mcg-web reviewed Jan 5, 2019
Co-Authored-By: Vincz <vincent@fullstack.pro>
Collaborator Author
| Hey @mcg-web ! Any idea on the failed check? Is my php-cs config outdated? |
Contributor
| @Vincz I think the phpcs.phar v2 has been updated that the reason why this failed, I will fix that directly on master branch. Thanks again for this contribution! |
Collaborator Author
| Ok, thank you! |
mcg-web approved these changes Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implement Fields builder, see #437