Remove auto mapping configuration #333
Conversation
mcg-web force-pushed the remove-auto-mapping-configuration branch from 264d1e5 to c50df7e Compare 
renatomefi left a comment
renatomefi left a comment There was a problem hiding this comment.
That looks amazing, should we put a new recipe on flex which already does the configuration for the types at least?
| Overblog\GraphQLBundle\Definition\Resolver\MutationInterface: | ||
| tags: ['overblog_graphql.mutation'] | ||
| | ||
| App\GraphQL\: |
There was a problem hiding this comment.
What's the idea of this one?
There was a problem hiding this comment.
It is the entry where the DI will actually look for the classes. But I'm not sure I'm really understanding your question.
There was a problem hiding this comment.
I'm afraid this sample is implying people have a GraphQL namespace within their source, which we don't actually know. So I'm asking to know if there's something else related to this namespace which I might have missed
There was a problem hiding this comment.
I should modify to resource: src/GraphQL instead as this was the default dir of auto mapping. What do you think of that, is it more explicit?
There was a problem hiding this comment.
Maybe we don't even need this declaration, or is necessary for something?
This is unlikely to work in a recipe as the base Kernel class provided by the fwb recipe does load packages di config first, and then which means definitions would be overwritten by: |
| Thanks for the tips @ogizanagi 👍 , well will just remove config entry in 0.12 recipe and leave programmers follow documentation if needed. |
mcg-web force-pushed the remove-auto-mapping-configuration branch 3 times, most recently from d1f0353 to c495e12 Compare This has been remove in favor of the Symfony 4+ service configuration.
mcg-web force-pushed the remove-auto-mapping-configuration branch from c495e12 to aff7f92 Compare 5 participants
Auto mapping configuration has been remove in favor of the Symfony 4+ service configuration.
TODO: Remove config entry from flex recipe for 0.12