the strugglebus is here... #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…re in parseConfigFile
Collaborator Author
| Please PR this into master when it's done so we have a record of the current 0.7.0 deployment |
austinjruby approved these changes Nov 13, 2019
Contributor
austinjruby left a comment
austinjruby left a comment There was a problem hiding this comment.
that's a lot of removed lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Webpack is kind of a pain for this project... I spent an hour trying to figure out how to fix dynamic requires (for our config file) and it gave me tons of errors.
So I undid that...
I propose that we add the port number to the config file, this way the user knows not to mess with that...
Also I'm very unhappy with how un-dry my code is because half of it is handling the initial GraphQuill: Activate, and then it's just an on-save listener. Maybe we fire off a save after the setup to trick it into sending the first sets of requests.
We need to do a code review and game plan... This code is pretty damn confusing now.