feat: update to angular 9 #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| @santoshyadav198613 thanks for raising this pr. is that ready for review? |
Contributor Author
| Hi @orizens , |
Owner
| @santoshyadav198613 have you verified unit tests are passing? |
Contributor Author
|
|
Owner
| travis build was failing. i fixed it. should be good now. |
Owner
| @santoshyadav198613 can you advice: should there be any breaking changes? |
Contributor Author
No breaking changes the update should be smooth. |
Contributor Author
| Hi @orizens , |
Owner
| thanks @santoshyadav198613 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
A similar PR may already be submitted!
Please search among the Pull request before creating one.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request.
Summary
This PR fixes/implements the following bugs/features