Editing functions of clos/ files

[pamoroso]

When I call ED with the name of a function of the file clos/WEB-EDITOR, such as WEB::WEB-WINDOW-CLOSE-FN or WEB::WEB-WINDOW-BUTTON-EVENT-FN, I would expect Medley to prompt whether to load the relevant definition and open SEdit to edit the code. Instead the system brings up the file manager type menu as if the function didn't exist or was unknown. The same happens with functions of other files under the clos/ directory of Medley's source tree.

Is the code in clos/ supposed to be editable? Does the WHEREIS database index that code?

I run the apps sysout.

[nbriggs]

Is it asking you to create a dummy definition? Or asking you which type of the multiple definitions of the function you want to edit?

[pamoroso]

It is asking me to create a dummy definition:

[rmkaplan]

What does WHEREIS say? (WHEREIS 'WEB-WINDOW-CLOSE-FN T) (Separate issue: If I qualify this with WEB::, it gets a package error because clos isn't loaded. What does WHEREIS do about packages? Same confusion as ED ?)

…

On Oct 2, 2025, at 11:46 AM, Paolo Amoroso ***@***.***> wrote: It is asking me to create a dummy definition: ed-web-editor.png (view on web) <https://github.com/user-attachments/assets/0e819a27-f776-425c-ad4f-0b75f8532ceb> — Reply to this email directly, view it on GitHub <#2308 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJKO2F76V66TD5REOX33VVXHDAVCNFSM6AAAAACIEJVJZGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTINJXG4YDOMI>. You are receiving this because you are subscribed to this thread.

[pamoroso]

It returns NIL:

5_ (FILESLOAD WHEREIS) {DSK}<home>paolo>medley>medley>internal>WHEREIS.;1 File created 26-Jun-90 19:35:02 WHEREISCOMS ({DSK}<home>paolo>medley>medley>internal>WHEREIS.;1) 6_ (WHEREIS 'WEB-WINDOW-CLOSE-FN T) NIL 

[rmkaplan]

If WHEREIS doesn't know about it, it doesn't exist for ED, so ED brings up the new-item prototype menu. Presumably clos is not included in the whereis scan. But if it had been included in the scan, would it only be possible to interrogate the database if the package was already separately loaded?

…

On Oct 2, 2025, at 12:16 PM, Paolo Amoroso ***@***.***> wrote: It returns NIL: 5_ (FILESLOAD WHEREIS) {DSK}<home>paolo>medley>medley>internal>WHEREIS.;1 File created 26-Jun-90 19:35:02 WHEREISCOMS ({DSK}<home>paolo>medley>medley>internal>WHEREIS.;1) 6_ (WHEREIS 'WEB-WINDOW-CLOSE-FN T) NIL — Reply to this email directly, view it on GitHub <#2308 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJNE75AUIBUXNAFT2GT3VV2Z3AVCNFSM6AAAAACIEJVJZGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTINJXG4ZDSMY>. You are receiving this because you commented.

[rmkaplan]

Is this in the EDITINTERFACE PR #2301 or master?

[pamoroso]

This is in master.

[pamoroso]

In a fresh session (FILESLOAD WEB-EDITOR) returns NIL, so it's apparently preloaded.

[pamoroso]

Passing a third argument of T to WHEREIS makes it search the database rather than just FILELST. But even with WHERE-IS loaded (WHEREIS 'WEB-WINDOW-CLOSE-FN T T) returns NIL.

[nbriggs]

You can look at the loadups/whereis.dribble and trivially determine that no CLOS code was scanned for the whereis.hash file, so it's not indexed and this (WHEREIS, and thus ED) is not going to do what you're expecting.

[masinter]

Something unusual about 'WHEREIS' -- someone rewrote it using more Common Lisp conventions in the code and implemented 'WHERE-IS', which is in library and included in sysout

But 'WHEREIS' is still in medley/internal. Probably should be moved to 'obsolete'.

[masinter]

3.5.1 Argument Mismatch Detection

• 3.5.1.1 Safe and Unsafe Calls
• 3.5.1.2 Too Few Arguments
• 3.5.1.3 Too Many Arguments
• 3.5.1.4 Unrecognized Keyword Arguments
• 3.5.1.5 Invalid Keyword Arguments
• 3.5.1.6 Odd Number of Keyword Arguments
• 3.5.1.7 Destructuring Mismatch
• 3.5.1.8 Errors When Calling a Next Method

[Anzus]

Historically all the CLOS files were not part of the base system but more akin to a library package one could add if wanted. The core files are pure Common Lisp, not managed. So if one loaded the environment files (which are managed) then the location would have been known at that point, just like any other managed file. This probably is the reason for  the current behavior.ArunOn Oct 2, 2025, at 6:13 PM, Larry Masinter ***@***.***> wrote: 3.5.1 Argument Mismatch Detection 3.5.1.1 Safe and Unsafe Calls 3.5.1.2 Too Few Arguments 3.5.1.3 Too Many Arguments 3.5.1.4 Unrecognized Keyword Arguments 3.5.1.5 Invalid Keyword Arguments 3.5.1.6 Odd Number of Keyword Arguments 3.5.1.7 Destructuring Mismatch 3.5.1.8 Errors When Calling a Next Method —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[rmkaplan]

The entry point WHEREIS is in FILEPKG, it calls XCL::HASH-FILE-WHERE-IS.

There is still the question of how the database interacts with package qualifiers, particularly if the query is about a symbol that is in the index but qualified with a package that has not yet been loaded.

[pamoroso]

I'm confused because, although WEB-EDITOR is apparently preloaded, ED can't access the functions in the file. In a fresh session:

4_ (PRINTDEF WEB-EDITORCOMS) [(COMS * WEB::FILE-HEADER-COMS) **COMMENT** **COMMENT** **COMMENT** **COMMENT** (DECLARE%: DONTCOPY (PROPS (WEB-EDITOR MAKEFILE-ENVIRONMENT) (WEB-EDITOR FILETYPE))) **COMMENT** **COMMENT** (VARIABLES WEB::DESTINATION-BROWSER) ; [...] (FNS WEB::WEB-WINDOW-AFTER-MOVE-FN WEB::WEB-WINDOW-BUTTON-EVENT-FN WEB::WEB-WINDOW-RESHAPE-FN WEB::WEB-WINDOW-CLOSE-FN PromptRead) (FNS WEB::WEB-WINDOW-EXPAND-FN) (FUNCTIONS WEB::WEB-WINDOW-ICON-FN) (BITMAPS WEB::*WEB-EDITOR-ICON-BM* WEB::*WEB-EDITOR-ICON-MASK*) (VARIABLES WEB::*WEB-EDITOR-TEMPLATE*) ; [...] (DECLARE%: DONTEVAL@LOAD DOEVAL@COMPILE DONTCOPY COMPILERVARS (ADDVARS (NLAMA) (NLAML) (LAMA WEB::WINDOW-WHEN-HELD-FN WEB::WINDOW-WHEN-HELD-FN WEB::WEB-WINDOW-EXPAND-FN WEB::WEB-WINDOW-RESHAPE-FN WEB::WEB-WINDOW-BUTTON-EVENT-FN WEB::WEB-WINDOW-AFTER-MOVE-FN] NIL 5_ (APROPOS "WEB-WINDOW-CLOSE-FN") WEB::WEB-WINDOW-CLOSE-FN -function: (WEB::WINDOW) NIL 6_ (ED 'WEB::WEB-WINDOW-CLOSE-FN :DONTWAIT) WEB::WEB-WINDOW-CLOSE-FN has no definitions. Select a type of dummy definition to install. 

Directly loading WEB-EDITOR.DFASL yields the same results. How can I edit the functions in WEB-EDITOR?

[pamoroso]

As hinted in #2314, if I LOAD 'PROP clos/WEB-EDITOR the File Manager does notice it and ED lets me edit WEB-EDITOR::WEB-WINDOW-CLOSE-FN.