Update fluentd example #1479
Merged
Update fluentd example #1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
markxnelson requested review from ddsharpe, hzhao-github, mgianatagh, mriccell, rjeberhard and rosemarymarano 
Contributor
rosemarymarano left a comment
rosemarymarano left a comment There was a problem hiding this comment.
One typo, otherwise, LGTM.
docs-source/content/samples/simple/elastic-stack/weblogic-domain/_index.md Outdated Show resolved Hide resolved
hzhao-github approved these changes Mar 18, 2020
Contributor
| Looks good to me |
rjeberhard approved these changes Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR updates the fluentd sample that we have in the docs. The current sample passes through the
timestampas astringwhich means you cannot do time-based queries like "before x" or "between x and y" or "in the last 15 minutes".The PR updates the sample so that the special
@timestampfield will be added, with typetimeand with the same value as thestring timestamp. This will allow users to do time based queries.