switched to using bash array in shell scripts #893
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…g quotes for paths with spaces
robertpatrick approved these changes May 9, 2021
rakillen approved these changes May 10, 2021
CarolynRountree approved these changes May 10, 2021
Member Author
| obsolete. Alternate way to accomplish the same thing without using bash merged in #900 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Switched to using bash arrays to cleanup issue with shell not removing quotes for paths with spaces. Passing value to scriptArgs as $* was causing the double-quote to not get removed.
Also, replaced old-style back-tick with $() syntax.