createDomain create LogFilter, XMLEntity Cache, and XML Registry earlier #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ow. Server/Log depends on LogFilter. Fixes #871
rakillen approved these changes Apr 15, 2021
rakillen requested changes Apr 15, 2021
Member
rakillen left a comment
rakillen left a comment There was a problem hiding this comment.
This covers the "select template" create, but needs to be implemented for __extend_domain (older) create.
CarolynRountree suggested changes Apr 15, 2021
Contributor
CarolynRountree left a comment
CarolynRountree left a comment There was a problem hiding this comment.
update javadoc to reflect removal of location
| def __create_mbeans_used_by_topology_mbeans(self, topology_folder_list): | ||
| """ | ||
| Create the entities that are referenced by domain, machine, server and server template attributes. | ||
| :param location: current location |
Contributor
There was a problem hiding this comment.
this javadoc is out of date.
rakillen approved these changes Apr 15, 2021
CarolynRountree approved these changes Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Create LogFilter, XMLEntity Cache, and XML Registry earlier in the flow. Server/Log depends on LogFilter. Fixes #871