Wdt 476 timeouts #733
Merged
Wdt 476 timeouts #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ddsharpe reviewed Sep 22, 2020
| undeploy.timeout=180000 | ||
| start.application.timeout=180000 | ||
| stop.application.timeout=180000 | ||
| set.server.groups.timeout=30000 No newline at end of file |
There was a problem hiding this comment.
add newline at the end of the file (more portable)
rakillen reviewed Sep 22, 2020
jshum2479 reviewed Sep 22, 2020
jshum2479 reviewed Sep 22, 2020
rakillen approved these changes Sep 23, 2020
rakillen reviewed Sep 23, 2020
| class_name=self.__class_name, method_name=_method_name) | ||
| self.wlst_helper.set_server_groups(server_name, server_groups) | ||
| self.wlst_helper.set_server_groups(server_name, server_groups, | ||
| self.model_context.get_model_config().get_set_server_grps_timeout()) |
There was a problem hiding this comment.
get_set_server_grps_timeout no method, s/b get_server_grps_timeout() ?
jshum2479 approved these changes Sep 23, 2020
ddsharpe approved these changes Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added a tool.properties file to the install image. This contains the timeout values (with values as discussed) which are configurable. The properties in this file are added to the model_context. If the file is not found or a property not found, the same predetermined value is set internally by model_context. A call to wlst_helper for one of these commands will look up the timeout value in the model_context and pass to the command.
The documentation for this change will be in a separate branch. Work in progress.